Node / meshtastic / Meshtastic-Android / files / core / ui / src / commonTest / kotlin / org / meshtastic / core / ui / component / LoraSignalIndicatorTest.kt

Displaying Raw • Download

T8b949e/*

* Copyright (c) 2026 Meshtastic LLC

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 3 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <https://www.gnu.org/licenses/>.

*/

Tff7b72package T7ee787org.meshtastic.core.ui.component

Tff7b72import T7ee787org.meshtastic.core.model.snrLimit

Tff7b72import T7ee787org.meshtastic.proto.Config.LoRaConfig.ModemPreset

Tff7b72import T7ee787kotlin.test.Test

Tff7b72import T7ee787kotlin.test.assertEquals

T8b949e/**

* Tests for preset-relative signal-quality rating (issue #5446). Quality is judged from SNR relative to the modem

* preset's demodulation floor; RSSI is intentionally not part of the rating.

*/

Tff7b72class T56d364LoraSignalIndicatorTest Tb4b4b4{

Tf0883e@Test

Tff7b72fun Td2a8ff`snrLimit follows spreading-factor demod floor per preset`Tb4b4b4(Tb4b4b4) Tb4b4b4{

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff7.5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3SHORT_FASTTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF7

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff7.5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3SHORT_TURBOTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF7

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff0fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3SHORT_SLOWTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF8

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff2.5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3MEDIUM_FASTTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF9

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3MEDIUM_SLOWTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF10

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff7.5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_FASTTb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF11

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff7.5fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_MODERATETb4b4b4.Te6edf3snrLimitTb4b4b4) T8b949e// SF11

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`LONG_SLOW uses physically-correct SF12 floor`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// Meshtastic-Apple's snrLimit() returns -7.5 here (the SF7 value, an apparent bug). The correct SF12

T8b949e// demodulation floor is -20 dB — see #5446.

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff2T79c0ff0fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_SLOWTb4b4b4.Te6edf3snrLimitTb4b4b4)

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff2T79c0ff0fTb4b4b4, Te6edf3ModemPresetTb4b4b4.Te6edf3VERY_LONG_SLOWTb4b4b4.Te6edf3snrLimitTb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`null preset falls back to the LongFast default limit`Tb4b4b4(Tb4b4b4) Tb4b4b4{

Tff7b72val Te6edf3noPresetTb4b4b4: Te6edf3ModemPreset? Tff7b72= Tff7b72null

Te6edf3assertEqualsTb4b4b4(Tff7b72-T79c0ff1T79c0ff7.5fTb4b4b4, Te6edf3noPresetTb4b4b4.Te6edf3snrLimitTb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`the issue's example minus 10 dB SNR rates GOOD on LongFast`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// The bug this issue fixes: a fixed threshold rated -10 dB as BAD, but on LongFast (floor -17.5) it is

T8b949e// 7.5 dB above the demod floor — an excellent signal.

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff1T79c0ff0fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_FASTTb4b4b4)Tb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`the same SNR is rated relative to the preset`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// -15 dB is comfortably above LongSlow's -20 floor but at/below ShortFast's -7.5 floor.

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff1T79c0ff5fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_SLOWTb4b4b4)Tb4b4b4)

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3BADTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff1T79c0ff5fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3SHORT_FASTTb4b4b4)Tb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`quality bands around the LongFast floor`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// limit = -17.5; FAIR within 5.5 dB below, BAD within 7.5 dB below, NONE beyond.

Tff7b72val Te6edf3preset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_FAST

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff1T79c0ff7fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3presetTb4b4b4)Tb4b4b4) T8b949e// > limit

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3FAIRTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff1T79c0ff7.5fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3presetTb4b4b4)Tb4b4b4) T8b949e// at limit

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3FAIRTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff2T79c0ff2fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3presetTb4b4b4)Tb4b4b4) T8b949e// > limit-5.5 (-23)

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3BADTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff2T79c0ff3fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3presetTb4b4b4)Tb4b4b4) T8b949e// >= limit-7.5 (-25)

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3NONETb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff3T79c0ff0fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3presetTb4b4b4)Tb4b4b4) T8b949e// < limit-7.5

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`a zero SNR reading is rated rather than treated as missing`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// 0 dB sits well above every preset's demod floor, so it is an excellent signal — not an absent one. If a

T8b949e// presence check ever folds zero into "unknown", this is the reading that disappears.

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= T79c0ff0fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_FASTTb4b4b4)Tb4b4b4)

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= T79c0ff0fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3SHORT_FASTTb4b4b4)Tb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`absent SNR is not a quality band`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// Quality has no member for "no measurement": callers must pass a non-null SNR, and the composables render

T8b949e// absence as Unknown rather than mapping it onto NONE (which asserts a measured, undemodulable signal).

Te6edf3assertEqualsTb4b4b4(T79c0ff4Tb4b4b4, Te6edf3QualityTb4b4b4.Te6edf3entriesTb4b4b4.Te6edf3sizeTb4b4b4)

Te6edf3assertEqualsTb4b4b4(Te6edf3listOfTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3NONETb4b4b4, Te6edf3QualityTb4b4b4.Te6edf3BADTb4b4b4, Te6edf3QualityTb4b4b4.Te6edf3FAIRTb4b4b4, Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4)Tb4b4b4, Te6edf3QualityTb4b4b4.Te6edf3entriesTb4b4b4.Te6edf3toListTb4b4b4(Tb4b4b4)Tb4b4b4)

Tb4b4b4}

Tf0883e@Test

Tff7b72fun Td2a8ff`RSSI does not influence the rating`Tb4b4b4(Tb4b4b4) Tb4b4b4{

T8b949e// Identical SNR + preset always yields the same verdict regardless of any RSSI (RSSI is display-only now).

Tff7b72val Te6edf3good Tff7b72= Te6edf3determineSignalQualityTb4b4b4(Te6edf3snr Tff7b72= Tff7b72-T79c0ff5fTb4b4b4, Te6edf3modemPreset Tff7b72= Te6edf3ModemPresetTb4b4b4.Te6edf3LONG_FASTTb4b4b4)

Te6edf3assertEqualsTb4b4b4(Te6edf3QualityTb4b4b4.Te6edf3GOODTb4b4b4, Te6edf3goodTb4b4b4)

Tb4b4b4}

Tb4b4b4}